Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cypress tests for partial page load on vocab home page #1474

Closed
wants to merge 1 commit into from
Closed

Add cypress tests for partial page load on vocab home page #1474

wants to merge 1 commit into from

Conversation

UnniKohonen
Copy link
Contributor

Reasons for creating this PR

Adding cypress tests for partial page load on vocab home page

Link to relevant issue(s), if any

  • Closes #

Description of the changes in this PR

  • Add cypress test for partial page load

Known problems or uncertainties in this PR

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@UnniKohonen UnniKohonen added this to the 3.0 milestone Jun 1, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kinow kinow mentioned this pull request Aug 1, 2023
Closed
4 tasks
@osma osma mentioned this pull request Mar 5, 2024
Closed
3 tasks
@osma
Copy link
Member

osma commented Mar 7, 2024

This code is old and difficult to salvage as so much around it has changed. But I implemented similar tests, partly inspired by these, in PR #1605. Closing this PR.

@osma osma closed this Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Skosmos 3.0 Backlog
Archived in project
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@UnniKohonen @osma